Skip to content

Conversation

@sushilk123
Copy link

Description

Adds missing CLI examples for Amazon Managed Grafana service commands to improve documentation coverage.

Changes

  • Add create-workspace example showing basic and advanced workspace creation with data sources
  • Add describe-workspace example for retrieving detailed workspace information and configuration
  • Add update-workspace example for modifying workspace settings and data source configurations
  • Improves documentation coverage for Amazon Managed Grafana service from 1 to 4 examples

Testing

Examples follow existing AWS CLI documentation format and provide realistic use cases for essential Grafana workspace management including creation, inspection, and configuration updates.

- Add create-workspace example showing basic and advanced workspace creation
- Add describe-workspace example for retrieving workspace details
- Add update-workspace example for modifying workspace configuration
- Improves documentation coverage for Amazon Managed Grafana service
@elysahall elysahall self-assigned this Oct 13, 2025
@elysahall elysahall added documentation This is a problem with documentation. pr:work-in-progress This PR is a draft and needs further work. labels Oct 13, 2025
@sushilk123
Copy link
Author

Hi @elysahall , Could you please review the PR?

Copy link
Collaborator

@elysahall elysahall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sushilk123, I only have a few requested changes. After you update your examples, commit and push to this PR. Then we should be good for maintainer review.

@@ -0,0 +1,55 @@
**To create a Grafana workspace**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**To create a Grafana workspace**
**Example 1: To create a Grafana workspace**

}
}

**To create a workspace with custom data sources**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**To create a workspace with custom data sources**
**Example 2: To create a workspace with custom data sources**

"grafanaVersion": "9.4"
}
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide a "For more information" link for every example in this request. See format in the contribution guide: https://aws.github.io/aws-cli/docs_styleguide.html#for-more-information-link

"dataSources": ["CLOUDWATCH", "PROMETHEUS", "XRAY"],
"notificationDestinations": ["SNS"]
}
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide a "For more information" link for every example in this request. See format in the contribution guide: https://aws.github.io/aws-cli/docs_styleguide.html#for-more-information-link

"stackSetName": "grafana-workspace-stack",
"workspaceRoleArn": "arn:aws:iam::123456789012:role/service-role/AmazonGrafanaServiceRole-g1234567890"
}
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide a "For more information" link for every example in this request. See format in the contribution guide: https://aws.github.io/aws-cli/docs_styleguide.html#for-more-information-link

"modified": "2023-05-07T21:30:45.789000+00:00"
}
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide a "For more information" link for every example in this request. See format in the contribution guide: https://aws.github.io/aws-cli/docs_styleguide.html#for-more-information-link

"notificationDestinations": ["SNS", "SES"],
"modified": "2023-05-07T21:35:12.456000+00:00"
}
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide a "For more information" link for every example in this request. See format in the contribution guide: https://aws.github.io/aws-cli/docs_styleguide.html#for-more-information-link

@@ -0,0 +1,43 @@
**To update a Grafana workspace**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**To update a Grafana workspace**
**Example 1: To update a Grafana workspace**

}
}

**To update workspace data sources**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**To update workspace data sources**
**Example 2: To update workspace data sources**

@elysahall elysahall assigned sushilk123 and unassigned elysahall Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation This is a problem with documentation. pr:work-in-progress This PR is a draft and needs further work.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants